From ceb01711acb75f7eda1d3b67ce583720c8811bd1 Mon Sep 17 00:00:00 2001
From: java110 <928255095@qq.com>
Date: 星期二, 30 八月 2022 00:12:10 +0800
Subject: [PATCH] 优化代码
---
service-common/src/main/java/com/java110/common/cmd/machine/UpdateMachineCmd.java | 26 ++++++++++++++++++--------
1 files changed, 18 insertions(+), 8 deletions(-)
diff --git a/service-common/src/main/java/com/java110/common/cmd/machine/UpdateMachineCmd.java b/service-common/src/main/java/com/java110/common/cmd/machine/UpdateMachineCmd.java
index 8fc4e77..92ca10e 100644
--- a/service-common/src/main/java/com/java110/common/cmd/machine/UpdateMachineCmd.java
+++ b/service-common/src/main/java/com/java110/common/cmd/machine/UpdateMachineCmd.java
@@ -25,12 +25,12 @@
import com.java110.core.factory.GenerateCodeFactory;
import com.java110.core.log.LoggerFactory;
import com.java110.dto.community.CommunityLocationDto;
+import com.java110.dto.machine.MachineDto;
import com.java110.intf.common.IMachineAttrInnerServiceSMO;
import com.java110.intf.common.IMachineV1InnerServiceSMO;
import com.java110.intf.community.ICommunityLocationV1InnerServiceSMO;
import com.java110.po.machine.MachineAttrPo;
import com.java110.po.machine.MachinePo;
-import com.java110.utils.constant.BusinessTypeConstant;
import com.java110.utils.exception.CmdException;
import com.java110.utils.util.Assert;
import com.java110.utils.util.BeanConvertUtil;
@@ -78,6 +78,14 @@
Assert.hasKeyAndValue(reqJson, "authCode", "蹇呭～锛岃濉啓閴存潈缂栫爜");
Assert.hasKeyAndValue(reqJson, "locationTypeCd", "蹇呭～锛岃閫夋嫨浣嶇疆绫诲瀷");
+ MachineDto machineDto = new MachineDto();
+ machineDto.setMachineCode(reqJson.getString("machineCode"));
+ List<MachineDto> machineDtos = machineV1InnerServiceSMOImpl.queryMachines(machineDto);
+
+ if (machineDtos != null && machineDtos.size() > 0 && !reqJson.getString("machineId").equals(machineDtos.get(0).getMachineId())) {
+ throw new CmdException("璁惧宸插瓨鍦�");
+ }
+
Assert.judgeAttrValue(reqJson);
}
@@ -85,14 +93,16 @@
@Override
@Java110Transactional
public void doCmd(CmdEvent event, ICmdDataFlowContext cmdDataFlowContext, JSONObject reqJson) throws CmdException {
- CommunityLocationDto communityLocationDto = new CommunityLocationDto();
- communityLocationDto.setCommunityId(reqJson.getString("communityId"));
- communityLocationDto.setLocationId(reqJson.getString("locationTypeCd"));
- List<CommunityLocationDto> locationDtos = communityLocationV1InnerServiceSMOImpl.queryCommunityLocations(communityLocationDto);
-
- Assert.listOnlyOne(locationDtos, "浣嶇疆涓嶅瓨鍦�");
MachinePo machinePo = BeanConvertUtil.covertBean(reqJson, MachinePo.class);
- machinePo.setLocationObjId(locationDtos.get(0).getLocationObjId());
+
+ if (!MachineDto.MACHINE_TYPE_MONITOR.equals(reqJson.getString("machineTypeCd"))) {
+ CommunityLocationDto communityLocationDto = new CommunityLocationDto();
+ communityLocationDto.setCommunityId(reqJson.getString("communityId"));
+ communityLocationDto.setLocationId(reqJson.getString("locationTypeCd"));
+ List<CommunityLocationDto> locationDtos = communityLocationV1InnerServiceSMOImpl.queryCommunityLocations(communityLocationDto);
+ Assert.listOnlyOne(locationDtos, "浣嶇疆涓嶅瓨鍦�");
+ machinePo.setLocationObjId(locationDtos.get(0).getLocationObjId());
+ }
int flag = machineV1InnerServiceSMOImpl.updateMachine(machinePo);
if (flag < 1) {
--
Gitblit v1.8.0